gopass config core.notifications false → "Error: Error setting config value: failed to stage config file: …"

[tchernomax]

Summary

max@host % gopass config core.notifications false

Error: Error setting config value: failed to stage config file: exit status 128: fatal: pathspec 'config' did not match any files

note: the setting is changed even if gopass output an error

Steps To Reproduce

gopass config core.notifications false

Expected behavior

no error

Environment

• OS: Archlinux
• OS version: Linux mde-claranet 6.5.4-arch2-1 Add template feature #1 SMP PREEMPT_DYNAMIC Thu, 21 Sep 2023 11:06:39 +0000 x86_64 GNU/Linux
• gopass Version: gopass 1.15.8 go1.21.1 linux amd64
• Installation method: package ( https://archlinux.org/packages/extra/x86_64/gopass/ )

Additional context

[tjex]

I'm also encountering this on Mac 13.5.

Not only this, but I have core.notifications = false set, but I've started getting notifications (clipboard copy, clear, etc)

[shiftleft1]

Also experiencing this in Ubuntu 20.04

[AnomalRoil]

I can reproduce on master.
This is because the .config/gopass folder is not using git I guess.

I suspect these might be the cause:

gopass/internal/action/config.go

Lines 92 to 97 in 875cdb9

	if err := st.Add(ctx, "config"); err != nil && !errors.Is(err, istore.ErrGitNotInit) {
	return fmt.Errorf("failed to stage config file: %w", err)
	}
	if err := st.Commit(ctx, "Update config"); err != nil && !errors.Is(err, istore.ErrGitNotInit) {
	return fmt.Errorf("failed to commit config: %w", err)
	}

Here's the DEBUG logs:

2023/11/20 21:35:37.767111 action/config.go:81	action.(*Action).setConfigValue	setting core.notifications to false for ""
2023/11/20 21:35:37.767116 gitconfig/config.go:109	gitconfig.(*Config).Set	set "core.notifications" to "false"
2023/11/20 21:35:37.767120 gitconfig/config.go:118	gitconfig.(*Config).Set	updating value
2023/11/20 21:35:37.767128 gitconfig/config.go:218	gitconfig.(*Config).rewriteRaw	input (core.notifications: false): ---------

[recipients]
	hash = <somebighash>
[mounts]
	path = /home/anomalroil/.local/share/gopass/stores/root
[mounts "sarl"]
	path = /home/anomalroil/.local/share/gopass/stores/sarl
[generate]
	autoclip = true
[core]
	notifications = true

-----------
2023/11/20 21:35:37.767143 gitconfig/config.go:226	gitconfig.(*Config).rewriteRaw	output: ---------

[recipients]
	hash = <somebighash>
[mounts]
	path = /home/anomalroil/.local/share/gopass/stores/root
[generate]
	autoclip = true
[core]
	notifications = false

-----------
2023/11/20 21:35:37.767151 gitconfig/config.go:242	gitconfig.(*Config).flushRaw	writing config to /home/anomalroil/.config/gopass/config: -----------

[recipients]
	hash = <somebighash>
[mounts]
	path = /home/anomalroil/.local/share/gopass/stores/root
[generate]
	autoclip = true
[core]
	notifications = false

--------------
2023/11/20 21:35:37.767236 gitfs/git.go:144	gitfs.(*Git).captureCmd	store.gitAdd: /usr/bin/git [git add --all --force config] (/home/anomalroil/.local/share/gopass/stores/root)
2023/11/20 21:35:37.768646 gitfs/git.go:144	gitfs.(*Git).captureCmd	store.gitDiffIndex: /usr/bin/git [git diff-index --quiet HEAD] (/home/anomalroil/.local/share/gopass/stores/root)
2023/11/20 21:35:37.771388 action/config.go:44	action.(*Action).Config	Error setting config value: failed to commit config: git has nothing to commit - stacktrace: failed to commit config: git has nothing to commit

which also seems to point at

gopass/internal/action/config.go

Lines 95 to 97 in 3da3cd5

	if err := st.Commit(ctx, "Update config"); err != nil && !errors.Is(err, istore.ErrGitNotInit) {
	return fmt.Errorf("failed to commit config: %w", err)
	}

being the issue