Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce build tags #1000

Merged
merged 1 commit into from Dec 26, 2018
Merged

Conversation

dominikschulz
Copy link
Member

Fixes #999

@dominikschulz dominikschulz added the feature Enhancements and new features label Nov 25, 2018
@dominikschulz dominikschulz added this to the 1.8.4 - Bugfix release milestone Nov 25, 2018
@dominikschulz dominikschulz self-assigned this Nov 25, 2018
metalmatze
metalmatze previously approved these changes Nov 28, 2018
@dominikschulz dominikschulz force-pushed the feature/issue-999 branch 7 times, most recently from 37da0cd to 9c0ed64 Compare December 26, 2018 06:59
@dominikschulz dominikschulz changed the title [WIP] Introduce build tags Introduce build tags Dec 26, 2018
@dominikschulz dominikschulz force-pushed the feature/issue-999 branch 3 times, most recently from f4645b7 to 76754cd Compare December 26, 2018 11:06
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@codecov-io
Copy link

Codecov Report

Merging #1000 into master will decrease coverage by 0.16%.
The diff coverage is 38.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   63.43%   63.26%   -0.16%     
==========================================
  Files         173      180       +7     
  Lines        9966     9976      +10     
==========================================
- Hits         6321     6311      -10     
- Misses       2858     2879      +21     
+ Partials      787      786       -1
Impacted Files Coverage Δ
pkg/action/xc/xc.go 39.72% <ø> (ø) ⬆️
main.go 27.69% <ø> (ø) ⬆️
pkg/backend/strings.go 40.82% <0%> (-43.05%) ⬇️
pkg/ctxutil/ctxutil.go 86.21% <0%> (-8.13%) ⬇️
pkg/action/clone.go 50% <0%> (-1.22%) ⬇️
pkg/store/sub/rcs.go 100% <100%> (+26.09%) ⬆️
pkg/store/sub/storage.go 100% <100%> (+83.82%) ⬆️
pkg/otp/otp.go 42.42% <100%> (ø) ⬆️
pkg/store/sub/crypto.go 100% <100%> (+12%) ⬆️
pkg/action/version.go 43.14% <100%> (+3.55%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0ed04...9093f76. Read the comment docs.

@dominikschulz dominikschulz merged commit cd157a0 into gopasspw:master Dec 26, 2018
@dominikschulz dominikschulz deleted the feature/issue-999 branch December 26, 2018 11:58
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants