Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve template handling output #1029

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

dominikschulz
Copy link
Member

Fixes #1026

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz dominikschulz added bug Defects ux User experience / User Interface related labels Dec 29, 2018
@dominikschulz dominikschulz added this to the 1.8.5 - Bugfix release milestone Dec 29, 2018
@dominikschulz dominikschulz force-pushed the fix/issue-1026 branch 2 times, most recently from 1e2a84c to 0991ff5 Compare December 29, 2018 19:06
Fixes gopasspw#1026

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@codecov-io
Copy link

Codecov Report

Merging #1029 into master will increase coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   63.23%   63.26%   +0.03%     
==========================================
  Files         180      180              
  Lines       10002    10015      +13     
==========================================
+ Hits         6324     6335      +11     
- Misses       2887     2889       +2     
  Partials      791      791
Impacted Files Coverage Δ
pkg/action/edit.go 36.36% <ø> (-1.37%) ⬇️
pkg/action/generate.go 62.92% <0%> (+1.04%) ⬆️
pkg/store/root/templates.go 62.16% <100%> (+3.34%) ⬆️
pkg/out/print.go 92.45% <100%> (+0.79%) ⬆️
pkg/action/templates.go 52.54% <33.33%> (-6.55%) ⬇️
pkg/store/sub/templates.go 63.08% <80%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f475c9...53e32d6. Read the comment docs.

@dominikschulz dominikschulz merged commit 42acfdf into gopasspw:master Dec 29, 2018
@dominikschulz dominikschulz deleted the fix/issue-1026 branch December 29, 2018 19:21
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Fixes gopasspw#1026

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects ux User experience / User Interface related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants