Support Windows #14
Support Windows #14
Conversation
|
Ah, should i make p-r from develop branch again? |
|
Yep. This PR should definitely target |
|
updated base of this p-r. |
action/init.go
Outdated
| @@ -5,9 +5,14 @@ import ( | |||
|
|
|||
| "github.com/fatih/color" | |||
| "github.com/justwatchcom/gopass/gpg" | |||
| "github.com/mattn/go-colorable" | |||
There was a problem hiding this comment.
I wonder why we'd need another color library along the existing one. If you believe your lib provides a benefit over the existing one feel free to open an separate PR to completely replace the old one, but for this PR I'd prefer if we could stick to the existing one.
fsutil/fsutil_windows.go
Outdated
|
|
||
| // Tempdir returns a temporary directory suiteable for sensitive data. On | ||
| // Windows, just return empty string for ioutil.TempFile. | ||
| func Tempdir() string { |
There was a problem hiding this comment.
The Tempdir function seems to be the only difference between fsutil_windows.go and fsutil_others.go.
Could you leave the common code in fsutil.go and only put the Tempdir function in fsutil_windows.go / fsutil_others.go?
|
Very nice PR overall, thanks so much. |
|
removed out variable. This was remaining to output color with color.GreenString(). It is not required by color.Green(). Also separated funcs in fsutil. |
|
Any progress on this? I'm looking forward for this feature :). |
|
This is already done. :) |
Can't wait for it to be merged then. |
|
rebased to master |
|
We'll try to get this one merged ASAP. |
Just separated codes