New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement dedicated summon provider (#1436) #1438
implement dedicated summon provider (#1436) #1438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good already.
Some cleanup and finishing the tests and this should be ready to merge.
Signed-off-by: Chris Drexler <ckolumbus@ac-drexler.de>
Signed-off-by: Chris Drexler <ckolumbus@ac-drexler.de>
Signed-off-by: Chris Drexler <ckolumbus@ac-drexler.de>
Signed-off-by: Chris Drexler <ckolumbus@ac-drexler.de>
f341f08
to
770739f
Compare
Test implemented, refactoring of outputting done. How can i fix the CommitCheck errors? |
Codecov Report
@@ Coverage Diff @@
## master #1438 +/- ##
==========================================
- Coverage 64.34% 64.09% -0.24%
==========================================
Files 203 205 +2
Lines 11592 11647 +55
==========================================
+ Hits 7458 7465 +7
- Misses 3323 3370 +47
- Partials 811 812 +1
Continue to review full report at Codecov.
|
CommitCheck wants a RELEASE_NOTES=... tag in all commits. This will be used to assemble the release notes. |
@dominikschulz could you maybe provide a link to some examples? What are the best practices for this in case of several (unimportant) check-ins? Squashing? |
Yes, we usually squash commits in a PR. |
@dominikschulz sorry for bothering you again:
so I squash everything and add one RELEASE_NOTES tag? |
Yes, that's how I'd it. |
…upport implement dedicated summon provider (gopasspw#1436) RELEASE_NOTES=[FEATURE] Add summon provider
initial implementation of a dedicated summon-provider implementation for gopass as the default output behavior of
gopass
violates thesummon
contract by adding all meta data.This implementation outputs only the secret, no other special handling is implemented.