Delete empty parent directories on gopass rm -r #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschulz
force-pushed
the
fix/issue-1723
branch
from
735acda
to
5c7c003
Compare
dominikschulz
force-pushed
the
fix/issue-1723
branch
from
5c7c003
to
a71e556
Compare
This adds house keeping around empty parent directories. They would have been left over in some cases. This adds more proetections to avoid that, i.e. removing empty parents on rm -r (not only rm) as well as fsck checks. Fixes gopasspw#1723 RELEASE_NOTES=[BUGFIX] Remove empty parents on gopass rm -r Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz
force-pushed
the
fix/issue-1723
branch
from
a71e556
to
03fe264
Compare
Codecov Report
@@ Coverage Diff @@
## master #1725 +/- ##
==========================================
- Coverage 58.11% 58.06% -0.05%
==========================================
Files 189 189
Lines 9035 9080 +45
==========================================
+ Hits 5250 5272 +22
- Misses 3193 3210 +17
- Partials 592 598 +6
Continue to review full report at Codecov.
|
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
This adds house keeping around empty parent directories. They would have been left over in some cases. This adds more proetections to avoid that, i.e. removing empty parents on rm -r (not only rm) as well as fsck checks. Fixes gopasspw#1723 RELEASE_NOTES=[BUGFIX] Remove empty parents on gopass rm -r Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds house keeping around empty parent directories. They would
have been left over in some cases. This adds more proetections to avoid
that, i.e. removing empty parents on rm -r (not only rm) as well as
fsck checks.
Fixes #1723
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org