Warn if throw-keyids is set #1759
Conversation
|
IMO this should be documented somewhere, because people that do not include key ids are typically doing it on purpose to try and stay anonymous and we don't want to undermine their effort if they think it is important for them, do we? |
|
Good point, yes. |
|
Well I disagree, this works well with Gopass since GPG will simply try ever secret key in the key ring during a decryption attempt if this option was used upon encryption. So Gopass itself is not hindered in anyway by the throw-id setting. |
|
The point is that some operations won't work as expected. With age it's similar and there is not option to disable that. So maybe we should only warn instead? |
Fixes gopasspw#1756 RELEASE_NOTES=[BUGFIX] Warn about --throw-keyids Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz
force-pushed
the
fix/issue-1756
branch
from
a347380
to
c47a2d1
Compare
dominikschulz
changed the title
|
Updated the PR to only warn about throw-keyids, not override it. |
| @@ -33,6 +33,7 @@ type GPG struct { | |||
| pubKeys gpg.KeyList | |||
| privKeys gpg.KeyList | |||
| listCache *lru.TwoQueueCache | |||
| throwKids bool | |||
There was a problem hiding this comment.
No kids were harmed in making this PR ;)
Fixes gopasspw#1756 RELEASE_NOTES=[BUGFIX] Warn about --throw-keyids Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Fixes #1756
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org