Don't prompt to retype password unnecessarily with age backend #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When gopass can't find a pinentry binary to use for prompting for a password to unlock an age keyring, it uses its own barebones fallback pinentry mechanism to prompt for a password in the terminal. This fallback pinentry always asked the user to retype their password and required the password match, even when decrypting a file using an already-existing password. I've updated it to only prompt for a repeat when necessary, and also made the password prompte messages less awkward. RELEASE_NOTES=[BUGFIX] Don't prompt to retype password unnecessarily with age backend when pinentry binary is unavailable. Signed-off-by: Faye Duxovni <duxovni@duxovni.org>
AnomalRoil
approved these changes
Sep 10, 2021
AnomalRoil
reviewed
Sep 10, 2021
dominikschulz
approved these changes
Sep 12, 2021
sthagen
added a commit
to sthagen/gopasspw-gopass
that referenced
this pull request
Sep 12, 2021
Don't prompt to retype password unnecessarily with age backend (gopasspw#1983)
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
…spw#1983) When gopass can't find a pinentry binary to use for prompting for a password to unlock an age keyring, it uses its own barebones fallback pinentry mechanism to prompt for a password in the terminal. This fallback pinentry always asked the user to retype their password and required the password match, even when decrypting a file using an already-existing password. I've updated it to only prompt for a repeat when necessary, and also made the password prompte messages less awkward. RELEASE_NOTES=[BUGFIX] Don't prompt to retype password unnecessarily with age backend when pinentry binary is unavailable. Signed-off-by: Faye Duxovni <duxovni@duxovni.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gopass can't find a pinentry binary to use for prompting for a password to unlock an age keyring, it uses its own barebones fallback pinentry mechanism to prompt for a password in the terminal. This fallback pinentry always asked the user to retype their password and required the passwords to match, even when decrypting a file using an already-existing password. I've updated it to only prompt for a repeat when necessary, and also made the password prompt messages less awkward.
RELEASE_NOTES=[BUGFIX] Don't prompt to retype password unnecessarily with age backend when pinentry binary is unavailable.
Signed-off-by: Faye Duxovni duxovni@duxovni.org