Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a MSI installer to our release pipeline #2001

Merged
merged 1 commit into from Sep 30, 2021
Merged

Conversation

AnomalRoil
Copy link
Member

This should allow us to tackle #1949 next.

RELEASE_NOTES=[ENHANCEMENT] Adding a MSI installer for Windows

Signed-off-by: Yolan Romailler <yolan@romailler.ch>
@AnomalRoil
Copy link
Member Author

Notice this isn't bundling currently the following items in the MSI:

  • bash.completion
  • CHANGELOG.md
  • fish.completion
  • LICENSE
  • README.md
  • zsh.completion

It's really just bundling the gopass.exe executable... I'm guessing the only annoying thing is the lack of the LICENSE file?

Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit 369870b into master Sep 30, 2021
@dominikschulz dominikschulz deleted the wip-1949 branch September 30, 2021 18:03
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
RELEASE_NOTES=[ENHANCEMENT] Adding a MSI installer for Windows

Signed-off-by: Yolan Romailler <yolan@romailler.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants