Move prompts and progress bars to stderr rather than stdout

[duxovni]

Having password prompts/etc on stdout is inconvenient in any context where the output is being piped to something other than a terminal. This change makes gopass more scripting-friendly, especially when using the age backend. It also removes a redundant password prompt message when the age backend asks for a password, since pinentry will display its own password prompt immediately afterward.

RELEASE_NOTES=[ENHANCEMENT] Move password prompts to stderr

Signed-off-by: Faye Duxovni duxovni@duxovni.org

[dominikschulz]

LGTM, but I'd like to have second pair of eyes on this.

[AnomalRoil]

I'd love to have a bit more context to understand when the stdout output is bugging you @duxovni.
What are the typical commands you are using in your scripts and how are you using them for this to be an issue for you?

I'm using gopass through scripts only and I thought we had all our basis covered on that front. (Although I'm using the GPG backend, so maybe it's not the case with the age backend, granted.)

That being said, it seems that POSIX mandates anyway to print interactive stuff on stderr anyway see PS1 here:

PS1
Each time an interactive shell is ready to read a command, the value of this variable shall be subjected to parameter expansion and written to standard error.

So doing the same seems like a sensible thing to do.

But I'll have to revisit a bit the codebase to check if you've changed really every instances of such stdout prompts or not, so I'll take a couple days to review, I'm afraid!

[duxovni]

I can believe that everything works fine for you with the GPG backend; the age backend is way worse in this regard. Even just gopass show gives me password prompts in the output. There's the redundant prompt I removed, and then all the prompts generated by the CLI pinentry fallback; in order to fix those, I also needed to fix all of the other termio prompts, which then required fixing the progress bars too. There may well be a lot of other prompts that are still on stdout, but this covers all the prompts that might come up during gopass show with the age backend, and then all the prompts that use the same codepaths as those prompts.

[dominikschulz]

Sorry for the sub-par experience with the age backend. It was really only a proof of concept for me (mostly to verify that Filos initial API was suitable for us). Thanks for your help in improving that!

[duxovni]

Oh, yeah, sorry that came off more critical than I intended! I really appreciate the work you've put in, it's great to have a usable pass-style password manager that doesn't need me to fiddle with GPG keys, and I'm looking forward to seeing this backend grow and develop further ❤️

[dominikschulz]

Oh, no worries. That didn't come across too critical or anything. I just would love to spend more time on the age backend but couldn't get myself to do that so far.

I gave the changes a short try and I think we can merge this as is and then fix any other occurences as we go.

[dominikschulz]

@AnomalRoil I don't want obsolete your plans but I think if you find other instances of us using Stdout incorrectly we could just have a follow up PR, ok?