Fix AutoClip handling on generate #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gopasspw#2023 RELEASE_NOTES=[BUGFIX] Fix AutoClip handling on generate Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
AnomalRoil
approved these changes
Nov 8, 2021
| @@ -120,7 +120,7 @@ func (s *Action) generateCopyOrPrint(ctx context.Context, c *cli.Context, name, | |||
| // copy to clipboard if: | |||
| // - explicitly requested with -c | |||
| // - autoclip=true, but only if output is not being redirected | |||
| if IsClip(ctx) || (s.cfg.AutoClip && !ctxutil.IsTerminal(ctx)) { | |||
| if IsClip(ctx) || (s.cfg.AutoClip && ctxutil.IsTerminal(ctx)) { | |||
There was a problem hiding this comment.
Maybe I should be replacing the content of my new function out.IsOutputRedirected by this then.
I'm not sure how ctxutil.IsTerminal(ctx) behaves when we are piping stuff but in a terminal.
| act.cfg.AutoClip = true | ||
| ctx := ctxutil.WithTerminal(ctx, false) | ||
| assert.NoError(t, act.Generate(gptest.CliCtxWithFlags(ctx, t, map[string]string{"force": "true"}, "foobar", "24"))) | ||
| assert.Contains(t, buf.String(), "Not printing secrets by default") |
There was a problem hiding this comment.
Are we printing this on StdOut? If so we might want to consider doing that on StdErr instead in a future PR.
There was a problem hiding this comment.
Yes, I think this goes to stdout right now.
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Fixes gopasspw#2023 RELEASE_NOTES=[BUGFIX] Fix AutoClip handling on generate Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2023
RELEASE_NOTES=[BUGFIX] Fix AutoClip handling on generate
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org