Disable possible git concurrency during fsck #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the default queue some git operations might still have been running when gopass did attempt to update exported keys. Disabling the queue in the inner loop makes more sense since it's more predictable and less brittle and using the queue there wouldn't help much anyway. Fixes gopasspw#2459 RELEASE_NOTES=[BUGFIX] Fix possible concurrency issues in fsck. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the default queue some git operations might still have been running when gopass did attempt to update exported keys. Disabling the queue in the inner loop makes more sense since it's more predictable and less brittle and using the queue there wouldn't help much anyway.
Fixes #2459
RELEASE_NOTES=[BUGFIX] Fix possible concurrency issues in fsck.
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org