Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Use goreleaser build for crosscompile #2635

Merged
merged 1 commit into from Sep 11, 2023
Merged

[BUGFIX] Use goreleaser build for crosscompile #2635

merged 1 commit into from Sep 11, 2023

Conversation

dominikschulz
Copy link
Member

This should make sure that we catch all platforms we target during release.

AnomalRoil
AnomalRoil previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Surprisingly, it works locally. Not sure why GHA don't like it.

@dominikschulz
[BUGFIX] Use goreleaser build for crosscompile
6926f4e 
This should make sure that we catch all platforms we target during
release.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz merged commit bdbda58 into gopasspw:master Sep 11, 2023
8 checks passed
@dominikschulz dominikschulz deleted the fix/cc branch September 11, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dominikschulz @AnomalRoil