[bugfix] Fix parsing of large secrets #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschulz
force-pushed
the
fix/issue-2594
branch
from
addbffa
to
a204707
Compare
The AKV secret type does rely on the bufio.Scanner and that uses a 64k limit by default. This change extends the limit to always match the supplied input data. This might exceed the available memory but not corrupt the output data. If we want to support payloads larger than the available memory we must make large changes to the parser. But since the issue is quite severe and we don't advertise to support huge playloads this seems to be a good compromise. Fixes gopasspw#2594 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz
force-pushed
the
fix/issue-2594
branch
from
a204707
to
8a2872f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AKV secret type does rely on the bufio.Scanner and that uses a 64k limit by default. This change extends the limit to always match the supplied input data. This might exceed the available memory but not corrupt the output data.
If we want to support payloads larger than the available memory we must make large changes to the parser. But since the issue is quite severe and we don't advertise to support huge playloads this seems to be a good compromise.
Fixes #2594