Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] use the same version of golangci-lint #2841

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 25, 2024

There are 2 different version of golangci-lint used inside the project, which lead to CI failure: https://github.com/gopasspw/gopass/actions/runs/8425200501/job/23070742289

gopass/Makefile

Line 136 in b8f0ff8

$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@latest; \

version: v1.56.1 # we have a list of linters in our .golangci.yml config file

Signed-off-by: Fernandez Ludovic <ldez@users.noreply.github.com>
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, again 😃

@dominikschulz dominikschulz merged commit ee3d518 into gopasspw:master Mar 26, 2024
8 checks passed
@ldez ldez deleted the fix/linter-version branch March 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants