Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Disble safecontent parsing if noparsing is requested #2855

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

dominikschulz
Copy link
Member

We can not parse and check the secret for suppressed keys if we are not supposed to parse the secret.

The actual change is one line, the rest are debug verbosity changes that did allow me to spot the issue
better (at default verbosity).

Fixes #2737

We can not parse and check the secret for suppressed keys if
we are not supposed to parse the secret.

Fixes gopasspw#2737

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added the bug Defects label Mar 31, 2024
@dominikschulz dominikschulz added this to the 1.15.13 milestone Mar 31, 2024
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnomalRoil AnomalRoil merged commit 946ccf4 into gopasspw:master Apr 2, 2024
8 checks passed
@dominikschulz dominikschulz deleted the fix/issue-2737 branch April 2, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gopass show --noparsing does not work as expected unless it's forced
2 participants