Audit freshly generated passwords #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/pwgen/pwgen.go
Outdated
| var password string | ||
|
|
||
| validator := crunchy.NewValidator() | ||
| for i := 0; i < 3 && validator.Check(password) != nil; i++ { |
There was a problem hiding this comment.
You rely on the fact that the validator complains if the inital password is empty?
There was a problem hiding this comment.
Correct. Could be done "cleaner" with a couple more lines of code, but then I'm not sure it's actually more readable. What do you think?
There was a problem hiding this comment.
I think it's fine. Just wanted to understand your reasoning.
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 64.03% 64.05% +0.02%
==========================================
Files 166 166
Lines 8882 8888 +6
==========================================
+ Hits 5687 5693 +6
Misses 2514 2514
Partials 681 681
Continue to review full report at Codecov.
|
Even generated passwords should be audited, since nothing stops the random generator from creating one called "password" (if you only try long enough or are particularly unlucky).
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Even generated passwords should be audited, since nothing stops the random generator from creating one called "password" (if you only try long enough or are particularly unlucky).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even generated passwords should be audited, since nothing stops the random
generator from creating one called "password" (if you only try long enough or
are particularly unlucky).