Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop WithContext methods #553

Closed
magiconair opened this issue Jan 27, 2022 · 1 comment · Fixed by #554
Closed

Drop WithContext methods #553

magiconair opened this issue Jan 27, 2022 · 1 comment · Fixed by #554
Milestone
v0.5.0

Comments

@magiconair
Copy link
Member

As announced in v0.3.0 we will drop all WithContext() methods in v0.5.0 and require that the non-WithContext() methods require a context.Context

func (c *Client) Read(...) {...}
func (c *Client) ReadWithContext(ctx context.Context, ...) { ... }

will become

func (c *Client) Read(ctx context.Context, ...) { ... }
@magiconair magiconair added this to the v0.5.0 milestone Jan 27, 2022
magiconair added a commit that referenced this issue Jan 27, 2022
@magiconair
drop WithContext
eea9f6d 
This patch drops the WithContext() methods and requires that all
methods have a context.

Fixes #553
@magiconair magiconair mentioned this issue Jan 27, 2022
Merged
@magiconair
Copy link
Member Author

This needs a rebase after v0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Drop WithContext methods and add context to all methods gopcua/opcua
1 participant
@magiconair