Make dial timeout configurable #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think my biggest concern with this change is that it enforces a dial timeout and that will be non-zero since it defaults to the request timeout. There is no way to have no dial timeout. This is different from before. |
|
I'll merge this and then we start testing this on our systems. |
kung-foo
reviewed
Sep 24, 2021
| } | ||
|
|
||
| // DialTimeout sets the timeout for establishing the UACP connection. | ||
| // Defaults to DefaultDialTimeout. Set to zero for no timeout. |
There was a problem hiding this comment.
Does DefaultDialTimeout exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the
uacp.Dialerconfigurable and allows to configure the dial timeout for establishing the uucp connection.Fixes #464