Skip to content

Commit

Permalink
Acceptance test for create, get and delete aggregate (#745)
Browse files Browse the repository at this point in the history
* Add acceptance test for create and delete aggregate #739, #740

* Add reusable functions for Create/Delete aggregates

* Fix acceptance test
  • Loading branch information
dstdfx authored and jtopjian committed Feb 2, 2018
1 parent bb5adf2 commit 1861349
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 0 deletions.
20 changes: 20 additions & 0 deletions acceptance/openstack/compute/v2/aggregates_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,23 @@ func TestAggregatesList(t *testing.T) {
tools.PrintResource(t, h)
}
}

func TestAggregatesCreateGetDelete(t *testing.T) {
client, err := clients.NewComputeV2Client()
if err != nil {
t.Fatalf("Unable to create a compute client: %v", err)
}

createdAggregate, err := CreateAggregate(t, client)
if err != nil {
t.Fatalf("Unable to create an aggregate: %v", err)
}
defer DeleteAggregate(t, client, createdAggregate)

aggregate, err := aggregates.Get(client, createdAggregate.ID).Extract()
if err != nil {
t.Fatalf("Unable to get an aggregate: %v", err)
}

tools.PrintResource(t, aggregate)
}
32 changes: 32 additions & 0 deletions acceptance/openstack/compute/v2/compute.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/gophercloud/gophercloud/openstack/compute/v2/flavors"
"github.com/gophercloud/gophercloud/openstack/compute/v2/servers"

"github.com/gophercloud/gophercloud/openstack/compute/v2/extensions/aggregates"
"golang.org/x/crypto/ssh"
)

Expand Down Expand Up @@ -570,6 +571,37 @@ func CreateVolumeAttachment(t *testing.T, client *gophercloud.ServiceClient, blo
return volumeAttachment, nil
}

// CreateAggregate will create an aggregate with random name and available zone.
// An error will be returned if the aggregate could not be created.
func CreateAggregate(t *testing.T, client *gophercloud.ServiceClient) (*aggregates.Aggregate, error) {
aggregateName := tools.RandomString("aggregate_", 5)
availableZone := tools.RandomString("zone_", 5)
t.Logf("Attempting to create aggregate %s", aggregateName)

createOpts := aggregates.CreateOpts{Name: aggregateName, AvailabilityZone: availableZone}

aggregate, err := aggregates.Create(client, createOpts).Extract()
if err != nil {
return nil, err
}

t.Logf("Successfully created aggregate %d", aggregate.ID)

return aggregate, nil
}

// DeleteAggregate will delete a given host aggregate. A fatal error will occur if
// the aggregate deleting is failed. This works best when using it as a
// deferred function.
func DeleteAggregate(t *testing.T, client *gophercloud.ServiceClient, aggregate *aggregates.Aggregate) {
err := aggregates.Delete(client, aggregate.ID).ExtractErr()
if err != nil {
t.Fatalf("Unable to delete aggregate %d", aggregate.ID)
}

t.Logf("Deleted aggregate: %d", aggregate.ID)
}

// DeleteDefaultRule deletes a default security group rule.
// A fatal error will occur if the rule failed to delete. This works best when
// using it as a deferred function.
Expand Down

0 comments on commit 1861349

Please sign in to comment.