Compute v2: Create aggregate #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
jtopjian
requested changes
Jan 28, 2018
|
|
||
| type CreateOpts struct { | ||
| // The name of the host aggregate. | ||
| Name string `json:"name"` |
There was a problem hiding this comment.
name is a required field, so this should be:
Name string `json:"name" required:"true"`| @@ -1,7 +1,21 @@ | |||
| /* | |||
| Package aggregates returns information about the host aggregates in the | |||
| Package aggregates creates aggregates and returns information about the host aggregates in the | |||
There was a problem hiding this comment.
Might as well rename this to:
Package aggregates manages information about the host aggregates in the
OpenStack cloud
|
@jtopjian Okay, will keep it in mind. |
|
Build succeeded.
|
jtopjian
approved these changes
Jan 29, 2018
|
@dstdfx Looks good to me. Thank you for working on this. :) |
dstdfx
added a commit
to dstdfx/gophercloud
that referenced
this pull request
Jan 30, 2018
dstdfx
added a commit
to dstdfx/gophercloud
that referenced
this pull request
Jan 31, 2018
jtopjian
pushed a commit
that referenced
this pull request
Feb 2, 2018
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
…gophercloud#739) * vendor: adding customdiff support * Networking v2: Deprecate subnet allocation_pools for allocation_pool This commit deprecates the openstack_networking_subnet_v2 allocation_pools argument in favor of allocation_pool. allocation_pool is a singular word which makes more sense to use declaratively. In addition, allocation_pools was originally a TypeList, but the OpenStack API will not respect the ordering defined by the user for multiple pools, which triggered unneeded diffs. allocation_pool is now a TypeSet which accounts for an unordered response. * Networking v2: Check allocation_pool first during subnet creation * Networking v2: Refactor same allocation pool detection * Networking v2: Add ConflictsWith for allocation_pool(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #738
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API doc:
Source code: