-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the Placement API #526
Comments
Sure - go for it :) For entire feature sets such as this, we like to break things up into per-method PRs. Picking something arbitrary from the link you gave, each of these would be a separate PR. You can bundle them up into a single Issue like how it was done in #287. Usually the first PR, GET, will be the largest since it'll include a lot of boilerplate code and the resource's resulting structure. You can "chain" branches/PRs together since the next branch/PR will naturally use code from the previous. If you submit PRs this way, prefix the title such as:
This can cause a rebase chain if a parent PR needed changes. It's admittedly a nuisance, but it does help keep things small. Let me know if you have any questions or need any help. |
@jaypipes Quick question: You mentioned the word "aggregates". Does the Placement API modify the functionality of the os-aggregates API calls? I was just about to open an issue to add |
@jtopjian Placement aggregates and Nova host aggregates are different concepts, actually. Both concepts will remain in each API for the foreseeable future. If you'd like to create an issue about os-aggregates and assign to me, go for it. :) |
@jtopjian Some of the differences between Nova host aggregates and Placement aggregates include:
[1] A resource provider can be a compute node, a volume group, an IP pool, pretty much anything. |
@jaypipes Got it. Thank you! |
On 12/22/2017 06:21 AM, Ildar Svetlov wrote:
@jaypipes <https://github.com/jaypipes> @jtopjian
<https://github.com/jtopjian> Hello! Do you know, does anybody work on
Nova host aggregates stuff? If not, let me do it, I'll create a separate
issue.
Apologies, Ildar, I have not yet had any time to do this. :( If you have
time, please do feel free to take it on.
Best,
-jay
|
Hi, np, os-aggregates support was merged! |
Since there hasn't been any activity on this for 2 years, I will create a PR to add the first placement APIs. |
* Manila: add share resource * Manila: comment out the shrink test * Manila: minor code review changes * Manila: add detailed error handling * Manila: add share_access resource (ACL) * Manila: minor code review and acl import support * Manila: add share access detailed error handling
@dkt26111 Do you think there is more work required to complete a basic coverage of the API? |
Add ParentProviderUUID to placement/v1/resourceproviders createOpts. Moreover restructure acceptance tests for consistency and for future additions. [Docs](https://docs.openstack.org/api-ref/placement/?expanded=create-resource-provider-detail) Relates to: gophercloud#526
Add ParentProviderUUID to placement/v1/resourceproviders createOpts. Moreover restructure acceptance tests for consistency and for future additions. [Docs](https://docs.openstack.org/api-ref/placement/?expanded=create-resource-provider-detail) Relates to: gophercloud#526
Add ParentProviderUUID to placement/v1/resourceproviders createOpts. Moreover restructure acceptance tests for consistency and for future additions. [Docs](https://docs.openstack.org/api-ref/placement/?expanded=create-resource-provider-detail) Relates to: gophercloud#526
The Placement API was introduced to OpenStack in the Newton release.
It allows administrative users to request and modify data about resource providers, inventory records, allocation records and grouping of providers (aggregates).
While the Placement API is currently a directory within the nova source tree, it is an entirely independent service from the OpenStack Compute API. It has its own service endpoint in the Keystone catalog and has its own REST API microversion history.
It would be great to add support to
gophercloud
for the placement API service.I'm eager to contribute this if cores give me the go-ahead.
The text was updated successfully, but these errors were encountered: