Add resource provider usages API for placement #1861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
@jtopjian This is ready for review. |
jtopjian
reviewed
Feb 28, 2020
|
|
||
| type ResourceProviderUsage struct { | ||
| ResourceProviderGeneration int `json:"resource_provider_generation"` | ||
| Usages Usage `json:"usages"` |
There was a problem hiding this comment.
I'm thinking this should be map[string]int?
I don't see any reference to DISK_GB etc in the placement code and the API docs mention:
The value is a dictionary of resource classes paired with the sum of the allocations of that resource class for this resource provider.
Given it's possible to create arbitrary resource classes, I think the result of Usages is going to be highly dynamic.
Thoughts?
There was a problem hiding this comment.
Sounds good to me. I'll make the change.
|
Build succeeded.
|
|
Implemented in #1862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #526
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API doc:
https://docs.openstack.org/api-ref/placement/#list-resource-provider-usages
API code:
https://github.com/openstack/placement/blob/master/placement/handlers/usage.py#L38