Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking v2: Fix up subnetpools #788

Closed
jtopjian opened this issue Feb 23, 2018 · 1 comment
Closed

Networking v2: Fix up subnetpools #788

jtopjian opened this issue Feb 23, 2018 · 1 comment

Comments

@jtopjian
Copy link
Contributor

jtopjian commented Feb 23, 2018

During implementation of https://github.com/terraform-providers/terraform-provider-openstack/pull/243, we discovered that it is not possible to query by Prefixes.

The fields which Neutron allows for listing is dynamic, based on the fields of the resource itself. I guess a limitation of this is fields which are arrays.

Doing further testing, I found that it is also not possible to list by created_at or updated_at.

And in reviewing the code, I found a few other areas I missed during the original code review:

  • The bool fields in ListOpts need to be *bool to allow values of false to be sent.
  • The result struct's CreatedAt and UpdatedAt need converted to time.Time. This is probably the first occurrence I've seen where the timestamp doesn't need a special conversion.
@jrperritt
Copy link
Contributor

closed by #789

cardoe pushed a commit to cardoe/gophercloud that referenced this issue Aug 27, 2020
Implement openstack_networking_qos_bandwidth_limit_rule_v2 datasource
with tests and website documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants