Networking v2: Fix subnetpools #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following fixes have been applied: * Removal of Prefixes from ListOpts * Changing ListOpts Shared to *bool * Changing ListOpts IsDefault to *bool * Changing the result CreatedAt to time.Time * Changing the result UpdatedAt to time.Time
1 similar comment
|
Build succeeded.
|
dklyle
approved these changes
Feb 23, 2018
jrperritt
approved these changes
Feb 23, 2018
|
Thanks, guys! |
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
Implement openstack_networking_qos_dscp_marking_rule_v2 datasource with tests and website documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #788
The following fixes have been applied:
/cc @dklyle
I've tested these fixes pretty extensively to make sure they're correct.
I'm not a fan of including
IDandtenant_idinListOpts, but since they were already merged and since they do work, I'm going to leave them.If someone has time to do a review of this, it would help move the Terraform PRs along.