Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LBaaSv2: Properly handle update TLS references #1723

Merged
merged 1 commit into from
Oct 3, 2019
Merged

LBaaSv2: Properly handle update TLS references #1723

merged 1 commit into from
Oct 3, 2019

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 1, 2019

Resolves #1722

@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 77.654% when pulling 2999dd1 on kayrus:handle-lbaas-tls-update into 863d540 on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 1, 2019

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 3, 2019

Build succeeded.

@kayrus kayrus changed the title LBaaSv2: Properly handle update TLS and AllowedCIDRs references LBaaSv2: Properly handle update TLS references Oct 3, 2019
@kayrus
Copy link
Contributor Author

kayrus commented Oct 3, 2019

@jtopjian ready for review.

jtopjian
jtopjian approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit d231593 into gophercloud:master Oct 3, 2019
@kayrus kayrus deleted the handle-lbaas-tls-update branch October 3, 2019 21:26
@kayrus kayrus mentioned this pull request Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lbaas: Listener's SniContainerRefs cannot be unset
3 participants
@kayrus @coveralls @jtopjian