Add providers support to openstack loadbalancer

[luis5tb]

This PR adds support for listing octavia providers

For #1773

Octavia Providers API: https://docs.openstack.org/api-ref/load-balancer/v2/#providers
Octavia Providers API code (list providers) :

• https://github.com/openstack/octavia/blob/master/octavia/api/v2/controllers/provider.py#L41
• https://github.com/openstack/octavia/blob/4a5c24ef6fcd3b5f198a20d780dedd7f7976296d/octavia/api/v2/types/provider.py#L20

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 12s
• gophercloud-acceptance-test : SUCCESS in 1h 35m 28s
• gophercloud-acceptance-test-ironic : SUCCESS in 30m 16s

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 49s
• gophercloud-acceptance-test : SUCCESS in 1h 54m 36s
• gophercloud-acceptance-test-ironic : SUCCESS in 29m 34s

[coveralls]

Coverage decreased (-0.8%) to 76.2% when pulling 4e3a521 on luis5tb:lbs-providers-support into bee6224 on gophercloud:master.

[dulek]

Looks fine to me!

[MaysaMacedo]

Looks good.

[jtopjian]

All, thank you for your collaboration with this work and submitting it.

Please note that we have a contributor tutorial which will explain additional steps required before we can merge this PR.

Please let me know if you have any questions.

[luis5tb]

All, thank you for your collaboration with this work and submitting it.

Please note that we have a contributor tutorial which will explain additional steps required before we can merge this PR.

Please let me know if you have any questions.

Thanks! I suppose I need to open an issue and properly format the PR commit message! Let me know if something else is missing

[jtopjian]

We'll also need to see the actual Python API implementation that "proves" this feature (https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-03-code-hunting.md).

Acceptance tests (https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-04-acceptance-testing.md) are also important to include, but if it's not possible or too difficult to include them, we can make exceptions.

[luis5tb]

We'll also need to see the actual Python API implementation that "proves" this feature (https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-03-code-hunting.md).

Acceptance tests (https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-04-acceptance-testing.md) are also important to include, but if it's not possible or too difficult to include them, we can make exceptions.

Sure! Already added the issue and updated the commit message with it and pointer to octavia providers api. As for the acceptance tests, I've already tested it, in conjunction with Cluster Network Operator making use of it: openshift/cluster-network-operator#391

[jtopjian]

Already added the issue and updated the commit message with it and pointer to octavia providers api

Thanks, but API documentation isn't what we're looking for. We need to see the actual Python service API implementation as described here:

https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-03-code-hunting.md

Specifically, see the area that reads "Examples of good code hunting can be seen here:".

As for the acceptance tests, I've already tested it,

Is it possible to add that test here?

https://github.com/gophercloud/gophercloud/tree/master/acceptance/openstack/loadbalancer/v2

[luis5tb]

Already added the issue and updated the commit message with it and pointer to octavia providers api

Thanks, but API documentation isn't what we're looking for. We need to see the actual Python service API implementation as described here:

https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-03-code-hunting.md

Specifically, see the area that reads "Examples of good code hunting can be seen here:".

Done!

As for the acceptance tests, I've already tested it,

Is it possible to add that test here?

https://github.com/gophercloud/gophercloud/tree/master/acceptance/openstack/loadbalancer/v2

I'll check! Thanks!

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 58s
• gophercloud-acceptance-test : SUCCESS in 1h 42m 40s
• gophercloud-acceptance-test-ironic : SUCCESS in 40m 39s

[jtopjian]

@luis5tb Thanks again for your work on this. I've left a comment regarding the Fields option that List supports. And per previous discussion, let me know if you have any issues including an acceptance test.

[luis5tb]

@luis5tb Thanks again for your work on this. I've left a comment regarding the Fields option that List supports. And per previous discussion, let me know if you have any issues including an acceptance test.

Thanks for your reviews! I'll give it a try later today to the acceptance tests! I'll let you know if I'm hitting any problem

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 15s
• gophercloud-acceptance-test : SUCCESS in 1h 52m 38s
• gophercloud-acceptance-test-ironic : SUCCESS in 28m 05s

[jtopjian]

@luis5tb Thank you for the updates. I should be able to review this again within the next day.

[jtopjian]

LGTM - thank you and everyone else for working on this.