Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect OVN octavia provider #391

Merged
merged 2 commits into from Dec 18, 2019
Merged

Autodetect OVN octavia provider #391

merged 2 commits into from Dec 18, 2019

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Nov 8, 2019

This makes the CNO to detect if ovn provider is configured in
octavia, and if that so configures kuryr to use it. Thanks to this
the need for a VM per svc is removed and loadbalancing is done by
using the ovn distributed loadbalancer (aka ovn flows)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2019
dulek
dulek reviewed Nov 19, 2019
View reviewed changes
pkg/platform/openstack/kuryr_bootstrap.go Show resolved Hide resolved
pkg/platform/openstack/kuryr_bootstrap.go Outdated
Delay: 10,
Timeout: 10,
Delay: 5,
Timeout: 4,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why those changes?

pkg/platform/openstack/kuryr_bootstrap.go Show resolved Hide resolved
@luis5tb luis5tb mentioned this pull request Nov 19, 2019
Merged
@luis5tb luis5tb force-pushed the ovn-octavia-autodetect branch 3 times, most recently from 7eb0f9a to cc269d5 Compare November 20, 2019 17:08
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2019
@luis5tb luis5tb requested a review from dulek November 22, 2019 15:34
@luis5tb luis5tb changed the title [WIP] Autodetect OVN octavia provider Autodetect OVN octavia provider Nov 22, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2019
@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 22, 2019

/test e2e-gcp

@luis5tb
Autodetect OVN octavia provider
8a04969 
This makes the CNO to detect if ovn provider is configured in
octavia, and if that so configures kuryr to use it. Thanks to this
the need for a VM per svc is removed and loadbalancing is done by
using the ovn distributed loadbalancer (aka ovn flows)
@luis5tb
Updating gophercloud dependencies
c1cdc53
@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 26, 2019

/retest

@dulek
Copy link
Contributor

dulek commented Nov 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 28, 2019

/test e2e-gcp-upgrade

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 28, 2019

/retest

@luis5tb
Copy link
Contributor Author

luis5tb commented Dec 16, 2019

/assign @squeed

@squeed
Copy link
Contributor

squeed commented Dec 16, 2019

/approve

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@luis5tb
Copy link
Contributor Author

luis5tb commented Dec 17, 2019

/test e2e-gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@luis5tb
Copy link
Contributor Author

luis5tb commented Dec 17, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f804733 into openshift:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@dcbw dcbw Awaiting requested review from dcbw

@dulek dulek Awaiting requested review from dulek

Assignees

@dulek dulek

@squeed squeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@luis5tb @dulek @squeed @openshift-ci-robot @openshift-bot @openshift-merge-robot