Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing IDFromName Functions #1897

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Removing IDFromName Functions #1897

merged 1 commit into from
Mar 16, 2020

Conversation

jtopjian
Copy link
Contributor

For #1896

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 78.746% when pulling 9355c8b on jtopjian:idfromname into 405a05e on gophercloud:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 78.746% when pulling 9355c8b on jtopjian:idfromname into 405a05e on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 15, 2020

Build succeeded.

@jtopjian jtopjian merged commit b49be8e into gophercloud:master Mar 16, 2020
@jtopjian jtopjian mentioned this pull request Mar 16, 2020
Closed
andreykaipov
andreykaipov reviewed Aug 12, 2020
View reviewed changes
openstack/compute/v2/servers/requests.go
// ImageName [optional; required if ImageRef is not provided] is the name of
// the image that contains the server's OS and initial state.
// Also optional if using the boot-from-volume extension.
ImageName string `json:"-"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was removing the ImageName and FlavorName options intended? It was a nice convenience to be able to pass the service client and not have to worry about calling IDFromName(...) ourselves. If so, it might be worthwhile to remove the ServiceClient as an option from the CreateOpts here and possibly other packages as it serves no purpose anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yes, it was intended though I do agree that it removes some well-received convenience.

This was referenced Aug 12, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreykaipov andreykaipov andreykaipov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtopjian @coveralls @andreykaipov