Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused ServiceClient from servers.CreateOpts #2004

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Remove unused ServiceClient from servers.CreateOpts #2004

merged 1 commit into from
Aug 14, 2020

Conversation

andreykaipov
Copy link
Contributor

Addresses #2003.

@andreykaipov
Copy link
Contributor Author

PR #1897 removed the need for this option.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 79.511% when pulling 5bcbeec on andreykaipov:remove-unused-code into 51f8fa1 on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 12, 2020

Build succeeded.

jtopjian
jtopjian approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 597f138 into gophercloud:master Aug 14, 2020
@andreykaipov andreykaipov deleted the remove-unused-code branch August 14, 2020 19:26
@andreykaipov andreykaipov mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreykaipov @coveralls @jtopjian