Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute v2: Add the user id to the get create and delete keypair #2186

Merged
merged 7 commits into from
Jul 2, 2021
Merged

Compute v2: Add the user id to the get create and delete keypair #2186

merged 7 commits into from
Jul 2, 2021

Conversation

jtopjian
Copy link
Contributor

For #2145
Supersedes #2146

@coveralls
Copy link

coveralls commented Jun 30, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 79.87% when pulling 0a5eba0 on jtopjian:keypair-add-userid into c9471fc on gophercloud:master.

@jtopjian
Copy link
Contributor Author

jtopjian commented Jul 1, 2021

@kayrus Let me know your thoughts on this. Generally, I'm not opposed to adding an opts field to existing functions, but since Key Pairs are part of the earliest and foundational resources in Gophercloud, I want to be careful and retain backwards compatibility.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 1, 2021

Build succeeded.

kayrus
kayrus reviewed Jul 1, 2021
View reviewed changes
openstack/compute/v2/extensions/keypairs/requests.go Outdated
// GetWithOpts is similar to Get, but can take a GetOpts struct.
// The options within GetOpts require the client to have a microversion set.
// The original Get function is retained for non-microverisoned requests.
func GetWithOpts(client *gophercloud.ServiceClient, name string, opts GetOptsBuilder) (r GetResult) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtopjian GetWithOpts func looks hacky. I'd extend the Get function, even if it breaks the previous API.

@kayrus
Copy link
Contributor

kayrus commented Jul 1, 2021

@jtopjian can you also add a UserID parameter to the List function?

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 1, 2021

Build failed.

@kayrus
Copy link
Contributor

kayrus commented Jul 1, 2021

@jtopjian thanks a lot. LGTM.

@jtopjian jtopjian merged commit 8c51993 into gophercloud:master Jul 2, 2021
This was referenced Jul 2, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayrus kayrus kayrus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtopjian @coveralls @kayrus @randomswdev