Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octavia: Add tags on pools #2237

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

nikParasyr
Copy link
Contributor

Add support for tags on octavia pools.
For #2236

Code

Add support for tags on octavia pools.
For gophercloud#2236
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.829% when pulling 253897d on nikParasyr:pools_tags into dc5a91f on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 15, 2021

Build failed.

@nikParasyr
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 15, 2021

Build failed.

@jtopjian
Copy link
Contributor

@nikParasyr The OpenLab failure can be ignored - there's something wrong with the test configuration.

This looks good to me. Is this ready to be merged?

@nikParasyr
Copy link
Contributor Author

@jtopjian Yes it is :)

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 5e2daf8 into gophercloud:master Oct 18, 2021
@nikParasyr nikParasyr deleted the pools_tags branch December 7, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants