Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1][CI] Drop periodic jobs from stable branch #2675

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Jul 6, 2023

Periodic jobs can't run against non-default branches with github action. Remove them from our stable branches to avoid confusion.

According to the github documentation [1]:

Scheduled workflows run on the latest commit on the default or base branch.

[1] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

Periodic jobs can't run against non-default branches with github
action. Remove them from our stable branches to avoid confusion.

According to the github documentation [1]:

    Scheduled workflows run on the latest commit on the default or base branch.

[1] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
@EmilienM
Copy link
Contributor

EmilienM commented Jul 6, 2023

not 100% necessary but useful for avoiding confusion.

@EmilienM
Copy link
Contributor

EmilienM commented Jul 6, 2023

LGTM, will merge after tests

@coveralls
Copy link

Coverage Status

coverage: 79.05%. remained the same when pulling a0b5dd4 on shiftstack:drop-periodics into efb556a on gophercloud:v1.

@pierreprinetti pierreprinetti added the semver:patch No API change label Jul 6, 2023
@EmilienM EmilienM merged commit b277c7b into gophercloud:v1 Jul 6, 2023
106 of 113 checks passed
@EmilienM EmilienM deleted the drop-periodics branch July 6, 2023 12:32
@EmilienM
Copy link
Contributor

EmilienM commented Jul 6, 2023

backport: #2679

@pierreprinetti
Copy link
Contributor

@EmilienM This patch was merged to v1 directly. What does "backport" mean in this context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch No API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants