v1: backport workflow/label changes for semver+label #2679
Conversation
These jobs should run on all branches, so drop the branch filter that were in place. For the CodeQL job, it seems like the github action syntax does not allow for a simplified `on` syntax, while at the same time using a `on.schedule`, so drop the periodic that we weren't paying attention to anyway. We have enough signal with just the PR jobs. (cherry picked from commit 9a407d6)
The stable branch is now `v1`. Non-breaking changes will be backported by applying a `backport-v1` label. (cherry picked from commit b984718)
The PR gophercloud#2656 caused all labels to be removed, because each run of the action eliminates all labels that aren't listed. This PR reintroduces our semver labels and the `good first issue` label in the repository. (cherry picked from commit d8128d3)
This isn't needed in `v1` branch.
|
Once the backporting automation is working propertly, I'd like to let it deal with the backports. WDYT? |
Do you mean you want to do the backports that I manually did, via the new automated system? |
| on: | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
As Pierre pointed out the other day, this workflow syncs the repository labels from what is defined in the .github/labels.yaml file. If we were to run this from the v1 branch, we would delete the backport-v1 label each time we had a PR triggering this workflow in the v1 branch. This was my mistake and we should revert it.
There was a problem hiding this comment.
In fact, we should even delete this workflow from the v1 branch.
There was a problem hiding this comment.
I'm a bit confused by what we want now, I'll let @pierreprinetti comment; you seem to have a stronger opinion on what we should be doing wrt these workflows in v1 branch. Let me know if you need help with that PR.
|
Closing in favor of #2683. |
Backport of the following commits from master:
So they can run on stable branches too.
Add the changes to semver & labels, useful for
v1branch.The bits around backports are removed in another commit (see below).
chore: Fix labels
Remove backport workflow & label
We don't want the backport workflow (and its labels) to exist in v1.