Fix AllowReauth reauthentication #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
force-pushed
the
fix_reauth
branch
from
d014799
to
6ddb76c
Compare
github-actions
bot
added
semver:major
pierreprinetti
force-pushed
the
fix_reauth
branch
from
6ddb76c
to
20fe5e6
Compare
github-actions
bot
added
semver:major
pierreprinetti
force-pushed
the
fix_reauth
branch
from
20fe5e6
to
5e6fd7b
Compare
github-actions
bot
added
semver:major
Due to an error in implementing the addition of `context.Context`, the reauth function catched the context passed when generating the ProviderClient, which could be long canceled when the reauthentication takes place. This is a breaking change: this patch changes the signature of the reauthentication function in the ProviderClient to accept a context.
pierreprinetti
force-pushed
the
fix_reauth
branch
from
5e6fd7b
to
ecb891e
Compare
github-actions
bot
added
semver:major
EmilienM
approved these changes
Feb 20, 2024
|
@pierreprinetti I'll let you merge it when you think it's ready. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an error in implementing the addition of
context.Context, the default reauth function caught the context passed when generating the ProviderClient, which could be long canceled when the reauthentication takes place.This is a breaking change: this patch changes the signature of the reauthentication function in the ProviderClient to accept a context.
Fixes #2931