[v1] Fix AllowReauth reauthentication #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
changed the title
vooon
reviewed
Feb 20, 2024
Due to an error in implementing the addition of context.Context, the default reauth function caught the context passed when generating the ProviderClient, which could be long canceled when the reauthentication takes place.
pierreprinetti
force-pushed
the
fix_reauth_v1
branch
from
8b33824
to
ac1ecd4
Compare
github-actions
bot
added
semver:patch
EmilienM
approved these changes
Feb 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an error in implementing the addition of context.Context, the default reauth function caught the context passed when generating the ProviderClient, which could be long canceled when the reauthentication takes place.
This is a modified backport of #2932.
Fixes #2931