Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal: fix handling of the "fields" query argument #2961

Merged
merged 1 commit into from
Mar 9, 2024
Merged

baremetal: fix handling of the "fields" query argument #2961

merged 1 commit into from
Mar 9, 2024

Conversation

dtantsur
Copy link
Contributor

@dtantsur dtantsur commented Mar 1, 2024

Ironic expects a comma-separated string. Add a new feature to
BuildQueryString to choose the format of slices.

Closes: #2960

@github-actions github-actions bot added the semver:patch No API change label Mar 1, 2024
@coveralls
Copy link

coveralls commented Mar 1, 2024 •
edited

Coverage Status

coverage: 77.275% (+0.002%) from 77.273%
when pulling 6cbf38d on dtantsur:baremetal-fields
into 9c117aa on gophercloud:master.

@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels Mar 7, 2024
@dtantsur dtantsur mentioned this pull request Mar 7, 2024
Merged
mandre
mandre reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a rather elegant solution and I quite like it.

mandre
mandre previously approved these changes Mar 8, 2024
View reviewed changes
@dtantsur dtantsur dismissed mandre’s stale review March 8, 2024 13:28

The merge-base changed after approval.

@dtantsur
Copy link
Contributor Author

dtantsur commented Mar 8, 2024

@dtantsur dtantsur dismissed mandre’s stale review

To be clear, I obvious did NOT do that :-/ (I miss gerrit so much)

@mandre
Copy link
Contributor

mandre commented Mar 8, 2024

@dtantsur dtantsur dismissed mandre’s stale review

To be clear, I obvious did NOT do that :-/ (I miss gerrit so much)

Let me try again, otherwise you might need a rebase after #2964 merged.

mandre
mandre previously approved these changes Mar 8, 2024
View reviewed changes
@dtantsur dtantsur dismissed mandre’s stale review March 8, 2024 15:28

The merge-base changed after approval.

@dtantsur
baremetal: fix handling of the "fields" query argument
6cbf38d 
Ironic expects a comma-separated string. Add a new feature to
BuildQueryString to choose the format of slices.

Closes: gophercloud#2960
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels Mar 8, 2024
@mandre mandre merged commit 477b8b0 into gophercloud:master Mar 9, 2024
17 checks passed
@mandre mandre added the backport-v1 This PR will be backported to v1 label Mar 9, 2024
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Mar 9, 2024
Closed
@mandre mandre mentioned this pull request Mar 10, 2024
Merged
@dtantsur dtantsur deleted the baremetal-fields branch March 10, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

Assignees
No one assigned
Labels
backport-v1 This PR will be backported to v1 semver:patch No API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

baremetal: invalid formats for lists in queries
3 participants
@dtantsur @coveralls @mandre