Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal: support for virtual media attach/detach #2974

Merged
merged 1 commit into from
Mar 11, 2024
Merged

baremetal: support for virtual media attach/detach #2974

merged 1 commit into from
Mar 11, 2024

Conversation

dtantsur
Copy link
Contributor

@dtantsur dtantsur commented Mar 7, 2024

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited

Coverage Status

coverage: 77.279% (+0.004%) from 77.275%
when pulling 457ab16 on dtantsur:baremetal-vmedia
into 4c21856 on gophercloud:master.

mandre
mandre reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Were you able to test this against a real environment?

It would probably be good to add acceptance tests as well with SkipReleasesBelow("master"). Please also add a comment about what version master will represent so that we can use a proper version name in the skip later on.

@dtantsur
Copy link
Contributor Author

dtantsur commented Mar 8, 2024

This looks good. Were you able to test this against a real environment?

I was, yes.

Regarding acceptance tests... I need to see what the fake backend does on this API. Probably returns an error.

@dtantsur
baremetal: support for virtual media attach/detach
457ab16 
Closes: gophercloud#2958

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Mar 11, 2024
@dtantsur dtantsur requested a review from mandre March 11, 2024 13:58
@elfosardo
Copy link
Contributor

/lgtm

mandre
mandre approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the acceptance tests 🚀

@mandre mandre merged commit 846cd21 into gophercloud:master Mar 11, 2024
17 checks passed
@dtantsur dtantsur deleted the baremetal-vmedia branch March 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

Assignees
No one assigned
Labels
semver:minor Backwards-compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

baremetal: add support for new virtual media API
4 participants
@dtantsur @coveralls @elfosardo @mandre