-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clouds: Fix the clouds.yaml locations #3040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is essentially adding that I am also removing the check on |
pierreprinetti
added
semver:major
Breaking change
and removed
semver:patch
No API change
labels
May 6, 2024
pierreprinetti
force-pushed
the
parse_clouds
branch
from
May 6, 2024 10:14
812dd17
to
3126f15
Compare
github-actions
bot
added
semver:patch
No API change
and removed
semver:major
Breaking change
labels
May 6, 2024
pierreprinetti
added
semver:major
Breaking change
and removed
semver:patch
No API change
labels
May 6, 2024
pierreprinetti
force-pushed
the
parse_clouds
branch
from
May 6, 2024 10:40
3126f15
to
8aa7e1a
Compare
github-actions
bot
added
semver:patch
No API change
and removed
semver:major
Breaking change
labels
May 6, 2024
pierreprinetti
added
semver:major
Breaking change
and removed
semver:patch
No API change
labels
May 6, 2024
pierreprinetti
force-pushed
the
parse_clouds
branch
from
May 6, 2024 12:32
8aa7e1a
to
0f6ab1b
Compare
github-actions
bot
added
semver:patch
No API change
and removed
semver:major
Breaking change
labels
May 6, 2024
pierreprinetti
force-pushed
the
parse_clouds
branch
from
May 6, 2024 12:35
0f6ab1b
to
9d00978
Compare
github-actions
bot
added
semver:patch
No API change
and removed
semver:patch
No API change
labels
May 6, 2024
pierreprinetti
added
semver:major
Breaking change
and removed
semver:patch
No API change
labels
May 6, 2024
Before this patch, all default locations were scanned for a `clouds.yaml` even when a match was found. The last found `clouds.yaml` replaced any previous finding, effectively reversing the order of priority for the locations.
pierreprinetti
force-pushed
the
parse_clouds
branch
from
May 6, 2024 12:38
9d00978
to
5eb171e
Compare
github-actions
bot
added
semver:patch
No API change
and removed
semver:major
Breaking change
labels
May 6, 2024
EmilienM
reviewed
May 6, 2024
EmilienM
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, all default locations were scanned for a
clouds.yaml
even when a match was found. The last foundclouds.yaml
replaced any previous finding, effectively reversing the order of priority for the locations.Fixes #3038