Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vpnaas: Update IPSec Policy #774

Merged
merged 8 commits into from
Mar 6, 2018

Conversation

simonre
Copy link
Contributor

@simonre simonre commented Feb 19, 2018

For #723

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L420

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 73.392% when pulling 3a6ed49 on simonre:vpnaas-ipsecpolicy-update into b922c6e on gophercloud:master.

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage increased (+0.003%) to 73.687% when pulling c00ca82 on simonre:vpnaas-ipsecpolicy-update into 32083cd on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 19, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 21, 2018

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

1 similar comment
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 21, 2018

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@simonre simonre changed the title [WIP] [PENDING #768] Vpnaas: Update IPSec Policy [WIP]Vpnaas: Update IPSec Policy Feb 27, 2018
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 27, 2018

Build succeeded.

@simonre simonre changed the title [WIP]Vpnaas: Update IPSec Policy Vpnaas: Update IPSec Policy Feb 27, 2018
@simonre
Copy link
Contributor Author

simonre commented Feb 27, 2018

@jtopjian This is ready for review

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonre Looks good. Just two small nits.

Also, per our other discussion about the Update functionality, I wanted to verify if this should be merged or wait until other resources are added in order for this to work.

"value": 7000
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the formatting here has gone awry. Normally some mismatched indentation is OK but let's fix this block up.


policy, err = ipsecpolicies.Update(client, policy.ID, updateOpts).Extract()
if err != nil {
t.Fatalf("Unable to update firewall: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/firewall/policy/

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 28, 2018

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@simonre
Copy link
Contributor Author

simonre commented Mar 5, 2018

@jtopjian This is ready. This can be merged, it does not depend on anything else.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 5, 2018

Build succeeded.

@jtopjian
Copy link
Contributor

jtopjian commented Mar 6, 2018

LGTM!

@jtopjian jtopjian merged commit 9b604dd into gophercloud:master Mar 6, 2018
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
* Networking V2: add QoS Policy resource

Implement "openstack_networking_qos_policy_v2" resource with acceptance
tests and website documentation.

* Networking V2: cleanup QoS Policies helpers

Move "QoSPolicyCreateOpts" type into
openstack/networking_qos_policy_v2.go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants