-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vpnaas: Update IPSec Policy #774
Vpnaas: Update IPSec Policy #774
Conversation
Build succeeded.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
1 similar comment
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
bb1d5b6
to
54e2f4f
Compare
Build succeeded.
|
@jtopjian This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonre Looks good. Just two small nits.
Also, per our other discussion about the Update functionality, I wanted to verify if this should be merged or wait until other resources are added in order for this to work.
"value": 7000 | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the formatting here has gone awry. Normally some mismatched indentation is OK but let's fix this block up.
|
||
policy, err = ipsecpolicies.Update(client, policy.ID, updateOpts).Extract() | ||
if err != nil { | ||
t.Fatalf("Unable to update firewall: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/firewall/policy/
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
330aff9
to
c00ca82
Compare
@jtopjian This is ready. This can be merged, it does not depend on anything else. |
Build succeeded.
|
LGTM! |
* Networking V2: add QoS Policy resource Implement "openstack_networking_qos_policy_v2" resource with acceptance tests and website documentation. * Networking V2: cleanup QoS Policies helpers Move "QoSPolicyCreateOpts" type into openstack/networking_qos_policy_v2.go.
For #723
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L420