Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vpnaas: Delete IPSec site connection #812

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

simonre
Copy link
Contributor

@simonre simonre commented Mar 7, 2018

Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.

For #723

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L252

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 73.763% when pulling 06a4dc9 on simonre:vpnaas-ipsecsiteconn-delete into c3bc092 on gophercloud:master.

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage increased (+0.03%) to 73.763% when pulling dd34b90 on simonre:vpnaas-ipsecsiteconn-delete into 24d38e2 on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 7, 2018

Build succeeded.

@simonre
Copy link
Contributor Author

simonre commented Mar 7, 2018

@jtopjian This will need a rebase after #810 is merged but other than that it's ready for review 😄

@simonre simonre force-pushed the vpnaas-ipsecsiteconn-delete branch from 06a4dc9 to dd34b90 Compare March 8, 2018 14:58
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 8, 2018

Build succeeded.

@simonre simonre changed the title [PENDING #810]Vpnaas: Delete IPSec site connection Vpnaas: Delete IPSec site connection Mar 8, 2018
@simonre
Copy link
Contributor Author

simonre commented Mar 8, 2018

@jtopjian This is ready for review

@jtopjian
Copy link
Contributor

jtopjian commented Mar 9, 2018

LGTM!

@jtopjian jtopjian merged commit 660c324 into gophercloud:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants