Fix Identity V3 Acceptance Tests #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
@zhangzujian Is this ready for review/merge? For all PRs that are ready for review, please post a comment requesting a review -- we'll consider the PR to still be a work in progress otherwise :) |
|
Ready for review. |
|
LGTM - thank you for fixing this :) |
5 tasks
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
Use a map instead of slice to perform lookups for sensitive headers. It should perfom better (O(1) on average) since it's a hashmap. Provide a simple unit test. Remove github.com/Unknwon/com dependency since is not needed anymore. Tidy vendored dependencies. This commit also sets Go version to 1.12 in go.mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #864