Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support acceptance test against OpenStack Queens release in OpenLab #868

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Support acceptance test against OpenStack Queens release in OpenLab #868

merged 1 commit into from
Apr 4, 2018

Conversation

kiwik
Copy link
Contributor

@kiwik kiwik commented Apr 2, 2018

For #869

Input comment "recheck stable/queens" in pull request comments, that
will trigger acceptance tests against OpenStack Queens release. OpenLab
will report test result in followint comments automatically.

And add support for Newton and Ocata release

  • "recheck stable/newton" -> test against OpenStack Newton release
  • "recheck stable/ocata" -> test against OpenStack Ocata release

Related-Bug: theopenlab/openlab#38

Input comment "recheck stable/queens" in pull request comments, that
will trigger acceptance tests against OpenStack Queens release. OpenLab
will report test result in followint comments automatically.

And add support for Newton and Ocata release
- "recheck stable/newton" -> test against OpenStack Newton release
- "recheck stable/ocata" -> test against OpenStack Ocata release

Related-Bug: theopenlab/openlab#38
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 2, 2018

Zuul encountered a syntax error while parsing its configuration in the
repo gophercloud/gophercloud on branch master. The error was:

extra keys not allowed @ data['recheck-queens']

The error appears in the following project stanza:

project:
name: gophercloud/gophercloud
check:
jobs:
- gophercloud-unittest
- gophercloud-acceptance-test
recheck-mitaka:
jobs:
- gophercloud-acceptance-test-mitaka
recheck-newton:
jobs:
- gophercloud-acceptance-test-newton
recheck-ocata:
jobs:
- gophercloud-acceptance-test-ocata
recheck-pike:
jobs:
- gophercloud-acceptance-test-pike
recheck-queens:
jobs:
- gophercloud-acceptance-test-queens

in "gophercloud/gophercloud/.zuul.yaml@master", line 1, column 3

@coveralls
Copy link

coveralls commented Apr 2, 2018

Coverage Status

Coverage remained the same at 73.9% when pulling fd734d9 on theopenlab:support-queens into 91d0b48 on gophercloud:master.

@jtopjian
Copy link
Contributor

jtopjian commented Apr 2, 2018

@kiwik Thanks for putting this together. Please let me know when it's ready to be merged.

@kiwik
Copy link
Contributor Author

kiwik commented Apr 3, 2018

@jtopjian , OpenLab side code have been merged, I will trigger the queens test later manually, if the test result is ok, let us merge the patch :-)

@kiwik
Copy link
Contributor Author

kiwik commented Apr 3, 2018

recheck stable/queens

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 3, 2018

Build failed.

@kiwik
Copy link
Contributor Author

kiwik commented Apr 3, 2018

Looks like it's test case issue, have been resolved in #865

2018-04-03 04:42:40.681545 | ubuntu-xenial | acceptance/openstack/identity/v3/endpoint_test.go:18: Fatalf format %v reads arg #1, but call has only 0 args
2018-04-03 04:42:40.681724 | ubuntu-xenial | acceptance/openstack/identity/v3/endpoint_test.go:39: Fatalf format %v reads arg #1, but call has only 0 args
2018-04-03 04:42:40.681827 | ubuntu-xenial | acceptance/openstack/identity/v3/endpoint_test.go:54: Fatalf format %v reads arg #1, but call has only 0 args
2018-04-03 04:42:40.681922 | ubuntu-xenial | acceptance/openstack/identity/v3/endpoint_test.go:77: Fatalf format %v reads arg #1, but call has only 0 args
2018-04-03 04:42:40.682016 | ubuntu-xenial | acceptance/openstack/identity/v3/projects_test.go:67: Fatalf format %v reads arg #1, but call has only 0 args
2018-04-03 04:42:40.682110 | ubuntu-xenial | acceptance/openstack/identity/v3/projects_test.go:94: Fatalf format %v reads arg #1, but call has only 0 args

@kiwik
Copy link
Contributor Author

kiwik commented Apr 3, 2018

recheck stable/queens

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 3, 2018

Build succeeded.

@jtopjian
Copy link
Contributor

jtopjian commented Apr 3, 2018

@kiwik Is this ready to be merged?

@kiwik
Copy link
Contributor Author

kiwik commented Apr 4, 2018

@jtopjian , yes, please merge the PR ,thanks.

@jtopjian
Copy link
Contributor

jtopjian commented Apr 4, 2018

@kiwik Thanks again for working on this :)

@jtopjian jtopjian merged commit c6152c7 into gophercloud:master Apr 4, 2018
@kiwik kiwik deleted the support-queens branch April 8, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants