Kadai1 rnakamine #26
Closed
Kadai1 rnakamine #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix go modules
Add Struct Commnet
ebiiim
reviewed
Feb 18, 2021
kadai1/imgconv/imgconv.go
Outdated
| return err | ||
| } | ||
|
|
||
| if err = os.Remove(i.FromPath); err != nil { |
There was a problem hiding this comment.
CLIツールとして、いきなり元ファイル消してくるのはちょっと怖いかも......
There was a problem hiding this comment.
@ebiiim
なるほどです！元ファイルも残す感じにしますね🙆♂️
-delオプションをつけて削除するかユーザー側で判断させるようにしました！
gosagawa
reviewed
Feb 23, 2021
kadai1/cli.go
Outdated
| flags.StringVar(&to, "to", "png", "Extensions after conversion") | ||
|
|
||
| if err := flags.Parse(args[1:]); err != nil { | ||
| fmt.Fprintln(c.errStream, err) |
There was a problem hiding this comment.
Fprintlnはファイルへの書き込みを行うので失敗してerrorを返す事があります。
そこのハンドリングをすべきなのと、後にエラーハンドリングの漏れをチェックしようとしたとき(それ用のerrcheckというツールがあります)全て引っかかってしまうので、Runのリターンとしてerrorを返すようにし、Run関数の外部でerrorの処理をする方が良さそうです。
| // GetConvertImages retrieves the images to be converted from the specified directory | ||
| func GetConvertImages(dir, from, to string) ([]ConvertImage, error) { | ||
| var images []ConvertImage | ||
| err := filepath.Walk(dir, func(path string, info os.FileInfo, err error) error { |
There was a problem hiding this comment.
filepath.Walkはディレクトリも走査するので、例えばtest.jpgというディレクトリがあった場合に変換対象に含まれてしまいます。あとで画像変換するときに落ちるのですが、この関数内でファイルかどうかはチェックしておいた方が良さそうです。
Add delete option
Add filetype check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題1
画像変換コマンドを作ろう
仕様
要件
実行結果
GoDoc