New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on Windows due to syscall package. #697

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
2 participants
@dmitshur
Member

dmitshur commented Sep 6, 2017

Move the syscall use into an internal helper package, behind a non-Windows build constraint.

Also switch from syscall to golang.org/x/sys/unix, since syscall documentation recommends doing so.

Fixes #695.

Fix build error on Windows due to syscall package.
Move the syscall use into an internal helper package, behind a
non-Windows build constraint.

Also switch from syscall to golang.org/x/sys/unix, since syscall
documentation recommends doing so.

Fixes #695.
@myitcv

myitcv approved these changes Sep 6, 2017

Thanks @shurcooL. Looks good to me

@dmitshur dmitshur merged commit 4b94c02 into master Sep 6, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@dmitshur dmitshur deleted the fix-syscall-windows branch Sep 6, 2017

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Sep 6, 2017

Member

Thanks for doing a review @myitcv!

Member

dmitshur commented Sep 6, 2017

Thanks for doing a review @myitcv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment