Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go get fails on Windows #695

Closed
200sc opened this issue Sep 6, 2017 · 1 comment
Closed

go get fails on Windows #695

200sc opened this issue Sep 6, 2017 · 1 comment
Assignees
@dmitshur
Labels
bug NeedsFix

Comments

@200sc
Copy link

200sc commented Sep 6, 2017 •
edited

What version of Go are you using (go version)?

go1.9 windows/amd64

What version of GopherJS are you using ?

GopherJS 1.7 (was attempting to update to 1.9)

What did you do?

go get -u github.com/gopherjs/gopherjs

What did you expect to see?

No errors.

What did you see instead?

..\..\gopherjs\gopherjs\tool.go:768:9: undefined: syscall.Rlimit
..\..\gopherjs\gopherjs\tool.go:769:10: undefined: syscall.Getrlimit
..\..\gopherjs\gopherjs\tool.go:769:28: undefined: syscall.RLIMIT_STACK

Looks like the runtime.GOOS check there needs to be in a file that has a !windows build tag.
@dmitshur
Copy link
Member

dmitshur commented Sep 6, 2017 •
edited

Thanks for reporting. Indeed. It's from the recently merged #687. /cc @myitcv We'll need to move that functionality behind a build tag, as you said.

@dmitshur dmitshur self-assigned this Sep 6, 2017
dmitshur added a commit that referenced this issue Sep 6, 2017
@dmitshur
Fix build error on Windows due to syscall package.
bfbfca8 
Move the syscall use into an internal helper package, behind a
non-Windows build constraint.

Also switch from syscall to golang.org/x/sys/unix, since syscall
documentation recommends doing so.

Fixes #695.
@dmitshur dmitshur mentioned this issue Sep 6, 2017
Merged
@hajimehoshi hajimehoshi mentioned this issue Sep 6, 2017
Closed
dmitshur added a commit that referenced this issue Sep 6, 2017
@dmitshur
Fix build error on Windows due to syscall package. (#697)
4b94c02 
Move the syscall use into an internal helper package, behind a
non-Windows build constraint.

Also switch from syscall to golang.org/x/sys/unix, since syscall
documentation recommends doing so.

Fixes #695.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
bug NeedsFix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitshur @200sc