Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: update version to 1.12-2 #914

Merged
merged 1 commit into from Apr 30, 2019
Merged

compiler: update version to 1.12-2 #914

merged 1 commit into from Apr 30, 2019

Conversation

hajimehoshi
Copy link
Member

Introducing syscall/js (#899) is so significant that we update
the version.

@hajimehoshi
Update version to 1.12-2
c26baa6 
Introducing `syscall/js` (#899) is so significant that we update
the version.
@hajimehoshi
Copy link
Member Author

Please take a look :)

dmitshur
dmitshur approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit subject should have a "compiler: " prefix since it's affecting the compiler package. Otherwise LGTM.

@hajimehoshi hajimehoshi changed the title Update version to 1.12-2 compiler: update version to 1.12-2 Apr 30, 2019
@hajimehoshi hajimehoshi merged commit 3e4dfb7 into master Apr 30, 2019
@hajimehoshi hajimehoshi deleted the 1.12-2 branch April 30, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitshur dmitshur dmitshur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hajimehoshi @dmitshur