Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: update version to 1.12-2 #914

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@hajimehoshi
Copy link
Member

commented Apr 30, 2019

Introducing syscall/js (#899) is so significant that we update
the version.

Update version to 1.12-2
Introducing `syscall/js` (#899) is so significant that we update
the version.

@hajimehoshi hajimehoshi requested a review from dmitshur Apr 30, 2019

@hajimehoshi

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

Please take a look :)

@dmitshur
Copy link
Member

left a comment

The commit subject should have a "compiler: " prefix since it's affecting the compiler package. Otherwise LGTM.

@hajimehoshi hajimehoshi changed the title Update version to 1.12-2 compiler: update version to 1.12-2 Apr 30, 2019

@hajimehoshi hajimehoshi merged commit 3e4dfb7 into master Apr 30, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hajimehoshi hajimehoshi deleted the 1.12-2 branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.