Skip to content
This repository has been archived by the owner on Apr 30, 2019. It is now read-only.

Add (*js.Value).InstanceOf() #2

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Add (*js.Value).InstanceOf() #2

merged 2 commits into from
Jun 25, 2018

Conversation

hajimehoshi
Copy link
Member

@hajimehoshi hajimehoshi commented Jun 25, 2018 •
edited
Loading

#1

@hajimehoshi
Copy link
Member Author

Could you take a look? Thank you!

neelance
neelance approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@neelance neelance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

js/js_test.go
@@ -64,3 +64,12 @@ func TestInt64(t *testing.T) {
t.Errorf("got %#v, want %#v", got, want)
}
}

func TestInstanceOf(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A second test for the negative case would be good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hajimehoshi
Copy link
Member Author

Thank you!

@hajimehoshi hajimehoshi merged commit 369ef62 into master Jun 25, 2018
@hajimehoshi hajimehoshi deleted the instanceof branch June 25, 2018 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neelance neelance neelance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hajimehoshi @neelance