Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more verdeps tests #205

Merged
merged 15 commits into from
Oct 22, 2016
Merged

Some more verdeps tests #205

merged 15 commits into from
Oct 22, 2016

Conversation

skeswa
Copy link
Contributor

@skeswa skeswa commented Oct 20, 2016

  • Refactored process_deps.go for better unit-testability
  • Wrote unit tests for process_deps.go
  • Refactored parse_go_file.go for better unit-testability
  • Wrote unit tests for parse_go_file.go
  • Reformatted some lines that tend to over-extend.

Shikkic
Shikkic reviewed Oct 20, 2016
View reviewed changes
lib/verdeps/process_deps.go
}

// TODO(skeswa): add a descriptive comment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to write this comment? 😄 haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw damn. I'll put that in a different PR.

Shikkic
Shikkic approved these changes Oct 20, 2016
View reviewed changes
Copy link
Member

@Shikkic Shikkic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are super in-depth and awesome to read. Real nice work 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+10.8%) to 58.745% when pulling 629160e on feature/verdeps-tests into 7f472fa on master.

@coveralls
Copy link

coveralls commented Oct 21, 2016 •
edited

Coverage Status

Coverage increased (+10.8%) to 58.745% when pulling c8e4180 on feature/verdeps-tests into 7f472fa on master.

@skeswa skeswa changed the title Feature/verdeps tests Some more verdeps tests Oct 22, 2016
@coveralls
Copy link

coveralls commented Oct 22, 2016 •
edited

Coverage Status

Coverage increased (+10.7%) to 58.648% when pulling ba1caa5 on feature/verdeps-tests into 7f472fa on master.

@coveralls
Copy link

coveralls commented Oct 22, 2016 •
edited

Coverage Status

Coverage increased (+10.6%) to 58.608% when pulling 7e39511 on feature/verdeps-tests into 7f472fa on master.

@coveralls
Copy link

coveralls commented Oct 22, 2016 •
edited

Coverage Status

Coverage increased (+11.3%) to 59.264% when pulling 4e43ae6 on feature/verdeps-tests into 7f472fa on master.

@skeswa skeswa merged commit cb561fa into master Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shikkic Shikkic Shikkic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skeswa @coveralls @Shikkic