Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hong kong locale does not always mean china #1397

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix: hong kong locale does not always mean china #1397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/make.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ func isInChinaWindows() bool {
return false
}
// Check if output contains `zh-cn;`
return strings.Contains(out, "zh-cn;") || strings.Contains(out, "zh-hk;")
return strings.Contains(out, "zh-cn;")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change

}

func isInChina() bool {
Expand All @@ -466,7 +466,7 @@ func isInChina() bool {
}
if strings.HasPrefix(out, prefix) {
out = out[len(prefix):]
return strings.HasPrefix(out, "zh_CN") || strings.HasPrefix(out, "zh_HK")
return strings.HasPrefix(out, "zh_CN")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second pointed out by anonymous help 馃憤馃徎 thank you

}
return false
}
Expand Down